AlinsRan commented on PR #2834: URL: https://github.com/apache/apisix-ingress-controller/pull/2834#issuecomment-5502721065
> the filter has to go inside the map funcs You're right, I agree — the `For()` predicate can't cover the map-func enqueues. Dropping that suggestion. One thing before merge: your third reviewer note. `syncNotify` is unconditional (`provider.go:231`) and the consumer loop has no debounce (`provider.go:277`), so each call is a full `Client.Sync`. EndpointSlice churn on another implementation's backends now reaches the new branch via `listHTTPRoutesByServiceRef` and resyncs our data planes every time. It doesn't need a `Provider.Delete` signature change — `Client.DeleteConfig` has one production caller (`provider.go:232`) and already discards the delta (`client.go:243`). Return `(StoreDelta, error)` and gate `syncNotify` on `len(delta.Deleted) > 0`. With that, good to merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
