johannes-engler-mw commented on PR #2834: URL: https://github.com/apache/apisix-ingress-controller/pull/2834#issuecomment-5506398319
Rebased on master; CI was red for two reasons, one of them mine. **Mine:** #2839 dropped the `gatewayv1alpha2` import from the L4 controllers, and the delete blocks here still used `gatewayv1alpha2.GroupVersion`. Beyond the build failure that would have been wrong at runtime — `label.GenLabel` derives the delete labels from that Kind/APIVersion, so the delete would no longer match what the update path writes. Now `gatewayv1.GroupVersion`, matching the sibling block above it. **Not mine:** `recordingProvider` is declared twice on master — `apisixconsumer_controller_test.go:45` (#2850) and `gateway_controller_publishservice_test.go:49` (#2846). `internal/controller` fails `go vet` on master alone; I checked a clean worktree with nothing of this branch in it. That fails `run-test` and `lint` for every open PR, and stops the e2e jobs at the image build. `096d47c7` fixes it by keeping the ApisixConsumer stub and giving it the `Update` counter the Gateway test needs. It is first on the branch and touches nothing else, so it can be cherry-picked on its own — happy to move it to a separate PR if you would rather. Re-verified locally after the rebase: `go vet` and the unit suite clean, and the `HTTPRoute with Multiple Gateway` e2e context passes on kind (3/3). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
