ShiningRush commented on a change in pull request #900:
URL: https://github.com/apache/apisix-dashboard/pull/900#discussion_r538007057
##########
File path: api/main.go
##########
@@ -35,6 +35,16 @@ import (
"github.com/apisix/manager-api/log"
)
+var Version string
+
+func printInfo() {
+ fmt.Fprint(os.Stdout, "The manager-api is running successfully!\n\n")
+ fmt.Fprintf(os.Stdout, "%-8s: %s\n", "Version", Version)
+ fmt.Fprintf(os.Stdout, "%-8s: %s:%d\n", "Listen", conf.ServerHost,
conf.ServerPort)
+ fmt.Fprintf(os.Stdout, "%-8s: %s\n", "Loglevel", conf.ErrorLogLevel)
Review comment:
Output listen info have two meanings:
- Tell user, manager api is running normal
- Show the serve info
If we output the log info, why we not output other config? We should give a
standard to tell other developer what should be print with begin info instead
of component's log,I think `relative path` is not reasonable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
