imjoey commented on a change in pull request #1344:
URL: https://github.com/apache/apisix-dashboard/pull/1344#discussion_r562373996
##########
File path: api/internal/core/storage/storage.go
##########
@@ -36,12 +36,13 @@ type WatchResponse struct {
type Keypair struct {
Key string
Value string
+ // If true, this keypair will NOT be processed in store.
+ Skipped bool
Review comment:
@ShiningRush
Cause the original skip check is done in Store, I guess your opinion is the
design 1. If not, we could also use design 2 instead. It's not a heavy
workload. 😄
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
