ShiningRush commented on a change in pull request #1344:
URL: https://github.com/apache/apisix-dashboard/pull/1344#discussion_r562377413
##########
File path: api/internal/core/storage/storage.go
##########
@@ -36,12 +36,13 @@ type WatchResponse struct {
type Keypair struct {
Key string
Value string
+ // If true, this keypair will NOT be processed in store.
+ Skipped bool
Review comment:
In fact, I prefer option 2, because invalid data should be cleaned from
the source. If the skip logic of storage requires store participation, then
this part of the content can be provided to the store as options instead of a
`Skipped` flag, which is just a notification to the store and does not have
much meaning.
BTW: I did not participate in the review of the previous skip logic, so I
don't know it before.
Sometimes I’m busy, so I can’t participate in every pr, sorry : (
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
