spacewander commented on a change in pull request #3910:
URL: https://github.com/apache/apisix/pull/3910#discussion_r603714643
##########
File path: apisix/plugins/limit-count.lua
##########
@@ -103,6 +103,9 @@ local schema = {
redis_timeout = {
type = "integer", minimum = 1, default = 1000,
},
+ redis_cluster_name = {
+ type = "string", default = "apisix-redis-cluster",
+ },
},
required = {"redis_cluster_nodes"},
Review comment:
For the reason I have said, the `redis_cluster_name` should be required.
##########
File path: apisix/plugins/limit-count/limit-count-redis-cluster.lua
##########
@@ -32,7 +32,8 @@ local mt = {
local function new_redis_cluster(conf)
local config = {
- name = "apisix-redis-cluster-" .. conf.name,
+ -- can set different name for different redis cluster
Review comment:
style: indent
##########
File path: apisix/plugins/limit-count.lua
##########
@@ -103,6 +103,9 @@ local schema = {
redis_timeout = {
type = "integer", minimum = 1, default = 1000,
},
+ redis_cluster_name = {
Review comment:
We should update the doc too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
