Firstsawyou commented on a change in pull request #3910: URL: https://github.com/apache/apisix/pull/3910#discussion_r603851023
########## File path: apisix/plugins/limit-count.lua ########## @@ -103,8 +103,11 @@ local schema = { redis_timeout = { type = "integer", minimum = 1, default = 1000, }, + redis_cluster_name = { + type = "string", + }, }, - required = {"redis_cluster_nodes"}, + required = {"redis_cluster_nodes","redis_cluster_name"}, Review comment: Bad style, it should be like this: ```suggestion required = {"redis_cluster_nodes", "redis_cluster_name"}, ``` ########## File path: docs/en/latest/plugins/limit-count.md ########## @@ -48,6 +48,7 @@ Limit request rate by a fixed number of requests in a given time window. | redis_database | integer | optional | 0 | redis_database >= 0 | When using the `redis` policy, this property specifies the database you selected of the Redis server, and only for non Redis cluster mode (single instance mode or Redis public cloud service that provides single entry). | | redis_timeout | integer | optional | 1000 | [1,...] | When using the `redis` policy, this property specifies the timeout in milliseconds of any command submitted to the Redis server. | | redis_cluster_nodes | array | optional | | | When using `redis-cluster` policy,This property is a list of addresses of Redis cluster service nodes. | +| redis_cluster_name | string | optional | | | When using `redis-cluster` policy,This property is the name of Redis cluster service nodes. | Review comment: It should be a comma in English, and the sentence does not end. `This` should be lowercase. ```suggestion | redis_cluster_name | string | optional | | | When using `redis-cluster` policy, this property is the name of Redis cluster service nodes. | ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org