leslie-tsang commented on a change in pull request #5248:
URL: https://github.com/apache/apisix/pull/5248#discussion_r732580848



##########
File path: Makefile
##########
@@ -33,55 +33,48 @@ ENV_OS_NAME            ?= $(shell uname -s | tr '[:upper:]' 
'[:lower:]')
 ENV_OS_ARCH            ?= $(shell uname -m | tr '[:upper:]' '[:lower:]')
 ENV_APISIX             ?= $(CURDIR)/bin/apisix
 ENV_GIT                ?= git
+ENV_TAR                ?= tar
+ENV_INSTALL            ?= install
 ENV_DOCKER             ?= docker
 ENV_DOCKER_COMPOSE     ?= docker-compose --project-directory $(CURDIR) -p 
$(project_name) -f $(project_compose_ci)
-ENV_NGINX              ?= nginx -p $(CURDIR) -c $(CURDIR)/conf/nginx.conf
-
-
-# OSX archive `._` cache file
-ifeq ($(ENV_OS_NAME), darwin)
-       ENV_TAR ?= COPYFILE_DISABLE=1 tar
-else
-       ENV_TAR ?= tar
+ENV_NGINX              ?= $(ENV_NGINX_EXEC) -p $(CURDIR) -c 
$(CURDIR)/conf/nginx.conf
+ENV_NGINX_EXEC         ?= $(shell which openresty 2>/dev/null || which nginx 
2>/dev/null)

Review comment:
       Got it, I will see what I can do




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to