leslie-tsang commented on a change in pull request #5248:
URL: https://github.com/apache/apisix/pull/5248#discussion_r733289365
##########
File path: Makefile
##########
@@ -38,7 +38,7 @@ ENV_INSTALL ?= install
ENV_DOCKER ?= docker
ENV_DOCKER_COMPOSE ?= docker-compose --project-directory $(CURDIR) -p
$(project_name) -f $(project_compose_ci)
ENV_NGINX ?= $(ENV_NGINX_EXEC) -p $(CURDIR) -c
$(CURDIR)/conf/nginx.conf
-ENV_NGINX_EXEC ?= $(shell which openresty 2>/dev/null || which nginx
2>/dev/null)
+ENV_NGINX_EXEC := $(shell which openresty 2>/dev/null || which nginx
2>/dev/null)
ENV_NGINX_PREFIX ?= $(shell $(ENV_NGINX_EXEC) -V 2>&1 | grep -Eo
'prefix=(.*)/nginx\s+' | grep -Eo '/.*/')
Review comment:
Make sense. Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
