jwrookie commented on a change in pull request #2362:
URL: https://github.com/apache/apisix-dashboard/pull/2362#discussion_r822663595



##########
File path: api/conf/schema.json
##########
@@ -3022,6 +3022,34 @@
                "upstream_hash_vars_schema": {
                        "pattern": 
"^((uri|server_name|server_addr|request_uri|remote_port|remote_addr|query_string|host|hostname)|arg_[0-9a-zA-z_-]+)$",
                        "type": "string"
+               },
+               "system_config":{

Review comment:
       Please keep the same opinion, I think both are fine, but according to 
the existing code style, it should be schema @bzp2010 @nic-chen 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to