bzp2010 commented on a change in pull request #2362:
URL: https://github.com/apache/apisix-dashboard/pull/2362#discussion_r822703792
##########
File path: api/conf/schema.json
##########
@@ -3022,6 +3022,34 @@
"upstream_hash_vars_schema": {
"pattern":
"^((uri|server_name|server_addr|request_uri|remote_port|remote_addr|query_string|host|hostname)|arg_[0-9a-zA-z_-]+)$",
"type": "string"
+ },
+ "system_config":{
Review comment:
> Please take a look at this issue, schema.json will be automatically
generated by control API only, if we add it manually, it will be difficult to
maintain. Do you have any suggestion?
@jwrookie I think the comment only needs to be `resolved` by the reviewer
himself, if it is always closed by your, other reviewers will not be aware of
the progress of the review and existing problems. This time I didn't notice the
content of this review. 😂
@nic-chen Please take a look at this issue, `schema.json` will be
automatically generated by control API only, if we add it manually, it will be
difficult to maintain. Do you have any suggestion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
