kwanhur commented on a change in pull request #6750:
URL: https://github.com/apache/apisix/pull/6750#discussion_r840623291



##########
File path: apisix/plugins/response-rewrite.lua
##########
@@ -115,6 +152,23 @@ function _M.check_schema(conf)
         end
     end
 
+    if conf.filters then
+        for _, filter in ipairs(conf.filters) do
+            for field, value in pairs(filter) do
+                if type(field) ~= 'string' then
+                    return false, 'invalid type as filter field'
+                end
+                if field ~= "replace" and value == "" then
+                    return false, 'invalid value as filter field ' .. field
+                end
+            end
+            local ok, err = re_compile(filter.regex, filter.options)
+            if not ok then
+                return false, err

Review comment:
       Done.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to