spacewander commented on a change in pull request #6750:
URL: https://github.com/apache/apisix/pull/6750#discussion_r840992845
##########
File path: apisix/plugins/response-rewrite.lua
##########
@@ -115,6 +152,23 @@ function _M.check_schema(conf)
end
end
+ if conf.filters then
+ for _, filter in ipairs(conf.filters) do
+ for field, value in pairs(filter) do
Review comment:
I mean a `require` for the filter.
##########
File path: apisix/plugins/response-rewrite.lua
##########
@@ -48,6 +52,40 @@ local schema = {
vars = {
type = "array",
},
+ filters = {
+ description = "a group of filters that modify response body\
Review comment:
We can use str concat
##########
File path: apisix/plugins/response-rewrite.lua
##########
@@ -115,6 +152,23 @@ function _M.check_schema(conf)
end
end
+ if conf.filters then
+ for _, filter in ipairs(conf.filters) do
+ for field, value in pairs(filter) do
Review comment:
@kwanhur
I mean a `require` for the filter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
