spacewander commented on code in PR #7092:
URL: https://github.com/apache/apisix/pull/7092#discussion_r878850182


##########
utils/linux-install-luarocks.sh:
##########
@@ -53,5 +53,13 @@ if [ -d ${OPENRESTY_PREFIX}/openssl111 ]; then
     OPENSSL_PREFIX=${OPENRESTY_PREFIX}/openssl111
 fi
 
+FOUND_PATH=$(echo "${PATH}" | grep -oP '(?<=:|)/usr/local/bin(?=:|)') || true
+if [[ "${FOUND_PATH}" == "" ]]; then
+   echo "the path /usr/local/bin is not included in the system default PATH 
variable, add PATH variable in ~/.bashrc."
+   echo "export PATH=$PATH:/usr/local/bin" >> ~/.bashrc

Review Comment:
   Can we leave bashrc untouched and only update $PATH for this shell? Just 
warn the user to modify $PATH by themselves as they may not use bash.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to