abdullah alamoudi has posted comments on this change. Change subject: TweetParser Extension ......................................................................
Patch Set 4: Can you please add test cases that test those functionalities. They don't need to be runtime tests within asterixdb system but unit tests would suffice. We can do: 1. you can create security parameters configuration files and we can create public credentials and use them. we can later disable the tests and change the credentials. of course we will have to adjust the test not to rely on the data since twitter data is expected to change I think (Not sure if there is a way to get consistent data). 2. Use Mockito to mock as much as you can and test different scenarios. >From experience, without tests, it will break very soon. One more thing: I think TwitterObjectFactory.getRawJSON sends another request to Twitter which I think would be bad for performance. can you verify? -- To view, visit https://asterix-gerrit.ics.uci.edu/1002 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7021e7b779de05b9ec999a8d5f8464fb0ab413c0 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang <xkk...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: No
