Xikui Wang has posted comments on this change. Change subject: TweetParser Extension ......................................................................
Patch Set 4: @Till Another submit addresses the Line # fix. Just a side note on the coding style part. I got quite a few comments from SonarQube that says Missing curly brace for if clause. Most of them are just one line statements. I am wondering is there any particular reason for that or it's just a fail-proof for future changes. I don't have strong opinion on this. Just out of curiosity due to my lack of project experience. :) -- To view, visit https://asterix-gerrit.ics.uci.edu/1002 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7021e7b779de05b9ec999a8d5f8464fb0ab413c0 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang <xkk...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Xikui Wang <xkk...@gmail.com> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: No
