Till Westmann has posted comments on this change. Change subject: Cast Record Before Insert for Open Indexes ......................................................................
Patch Set 6: Code-Review+1 (3 comments) Still needs Yingyi's rewriting expertise ... https://asterix-gerrit.ics.uci.edu/#/c/997/6/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/AsterixLSMInsertDeleteOperatorNodePushable.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/AsterixLSMInsertDeleteOperatorNodePushable.java: Line 145: } This indicates that we haven't gotten this part of exception handling right yet. Needs to be fixed, but not in this change. https://asterix-gerrit.ics.uci.edu/#/c/997/6/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/cast/ARecordCaster.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/cast/ARecordCaster.java: Line 238: requiredTypeTag.toString()); Don't need the toString() here .. https://asterix-gerrit.ics.uci.edu/#/c/997/6/hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/AssignRuntimeFactory.java File hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/AssignRuntimeFactory.java: Line 181: "Error evaluating tuple %1$s in AssignRuntime", e, tupleIndex); Seems that $1s would be replaced by 'e', not 'tupleIndex'. Is that intended? -- To view, visit https://asterix-gerrit.ics.uci.edu/997 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0eef5813ddbfe1b9c518cd7f92d37c95e8486914 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <bamou...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
