Yingyi Bu has posted comments on this change. Change subject: Cast Record Before Insert for Open Indexes ......................................................................
Patch Set 6: Code-Review+1 (1 comment) Just one minor comment. https://asterix-gerrit.ics.uci.edu/#/c/997/6/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java: Line 251: LogicalVariable castedRecVar = context.newVar(); move line 250-252 into the next if block? -- To view, visit https://asterix-gerrit.ics.uci.edu/997 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0eef5813ddbfe1b9c518cd7f92d37c95e8486914 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <bamou...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
