Till Westmann has posted comments on this change. Change subject: Add Asterix Extension Manager ......................................................................
Patch Set 7: (2 comments) A few more comments for patchset 7 in StopActiveRuntimeOperatorDescriptor.java and ILangExtension.java. https://asterix-gerrit.ics.uci.edu/#/c/1017/7/asterixdb/asterix-active/src/main/java/org/apache/asterix/active/runtime/StopActiveRuntimeOperatorDescriptor.java File asterixdb/asterix-active/src/main/java/org/apache/asterix/active/runtime/StopActiveRuntimeOperatorDescriptor.java: Line 40: public StopActiveRuntimeOperatorDescriptor(IOperatorDescriptorRegistry spec, ActiveRuntimeId runtimeId) { This class is never used. So I'm wondering if there's something we can do to test it anyway. https://asterix-gerrit.ics.uci.edu/#/c/1017/7/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/base/ILangExtension.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/base/ILangExtension.java: Line 44: ILangCompilationProvider getAqlLangCompilationProvider(); It seems that the extension mechanism shouldn't hard-code the AQL/SQL++ duality. Would it make sense to introduce a value/enum for the language for now? (At some point, I'd expect the support of more than one extension. Then we could have language extensions for different languages, but I think that for now we should just add an issue to be addressed when we support multiple extensions ..) -- To view, visit https://asterix-gerrit.ics.uci.edu/1017 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I280268495cc3aad00f898cba21f7299f7120ce5c Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <bamou...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Steven Jacobs <sjaco...@ucr.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
