abdullah alamoudi has posted comments on this change. Change subject: Add Asterix Extension Manager ......................................................................
Patch Set 10: @Yingyi, I will go over the inner comments but want to respond to the two outer comments here: 1. insertion for dataset with meta is still not allowed. but I moved the decision from the method in LangExpressionToPlanTranslator to the implementation of the dataset. Say someone wants to extend the dataset with a dataset that has meta and allows upsert for some cases, this enable the extension to basically have the decision in their implementation of the dataset object. 2. the copy and setOperatorId are needed if one wants to take operators from a compiled job and use them in a newly created job. For example, the new feed implementation will make use of these since it will combine a list of jobs into a single job. Otherwise, the activity id will not be updated which would lead to many runtime errors. -- To view, visit https://asterix-gerrit.ics.uci.edu/1017 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I280268495cc3aad00f898cba21f7299f7120ce5c Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <bamou...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Steven Jacobs <sjaco...@ucr.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: No
