Michael Blow has posted comments on this change. Change subject: [ASTERIXDB-2516][RT] Make asterix types comparators singleton and stateless ......................................................................
Patch Set 2: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/3255/2/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/comparators/ACirclePartialBinaryComparatorFactory.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/comparators/ACirclePartialBinaryComparatorFactory.java: PS2, Line 47: private static final class ACirclePartialBinaryComparator implements should we leave this as an anonymous nested class? i don't have a strong opinion, just noticed the extra diff PS2, Line 50: throws HyracksDataException i guess we don't actually throw here, it seems we wrap in an illegalstate. why do we wrap if we are allowed to throw a hyracksdataexception? -- To view, visit https://asterix-gerrit.ics.uci.edu/3255 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65972162ed2cf14d1f2654dbf00442aa35dd5c01 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
