Till Westmann has posted comments on this change. Change subject: [ASTERIXDB-2516][RT] Make asterix types comparators singleton and stateless ......................................................................
Patch Set 2: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/3255/2/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/comparators/ACirclePartialBinaryComparatorFactory.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/comparators/ACirclePartialBinaryComparatorFactory.java: PS2, Line 37: INSTANCE_COMP Would it make sense to call this COMPARATOR? It would be used in other code as ACirclePartialBinaryComparatorFactory.COMPARATOR, which seems ok. https://asterix-gerrit.ics.uci.edu/#/c/3255/2/hyracks-fullstack/hyracks/hyracks-hdfs/src/main/java/org/apache/hyracks/hdfs/lib/RawBinaryComparatorFactory.java File hyracks-fullstack/hyracks/hyracks-hdfs/src/main/java/org/apache/hyracks/hdfs/lib/RawBinaryComparatorFactory.java: PS2, Line 24: TODO It seems that we should remove the one is AsterixDB. -- To view, visit https://asterix-gerrit.ics.uci.edu/3255 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65972162ed2cf14d1f2654dbf00442aa35dd5c01 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
