>From Hussain Towaileb <[email protected]>:
Hello Anon. E. Moose #1000171, Till Westmann, Ali Alsuliman, Jenkins, Dmitry
Lychagin,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4023
to look at the new patch set (#13).
Change subject: [ASTERIXDB-2667][FUN] Share code base between string functions
......................................................................
[ASTERIXDB-2667][FUN] Share code base between string functions
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- String functions concat, string_concat and string_join
now share the same code instead of each having a different
evaluator class.
- Added test cases for string_join function.
- Added support to deep missing/null checking in list
items. Now it's possible to give a deeper (list items)
missing value a higher priority over null arguments
outside a list between parameters.
Example:
somefun([1, missing], null);
It's possible to deeply check the list items first,
and hence return a missing, or only do first level check
and output would be null.
Change-Id: I41b644c6841b222d1c6c529b2f9189f42178e28c
---
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/join/001/join.000.ddl.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/join/001/join.001.update.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/join/001/join.002.query.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/join/001/join.003.ddl.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/join/002/join.000.ddl.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/join/002/join.001.update.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/join/002/join.002.query.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/join/002/join.003.ddl.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/join/003/join.000.query.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/join/004/join.000.query.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/results/string/join/001/join.002.adm
A
asterixdb/asterix-app/src/test/resources/runtimets/results/string/join/002/join.002.adm
A
asterixdb/asterix-app/src/test/resources/runtimets/results/string/join/003/join.000.adm
A
asterixdb/asterix-app/src/test/resources/runtimets/results/string/join/004/join.000.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
A
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ConcatStringEval.java
M
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/PointableHelper.java
M
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/StringConcatDescriptor.java
M
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/StringJoinDescriptor.java
M
hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/string/UTF8StringUtil.java
20 files changed, 738 insertions(+), 238 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/23/4023/13
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4023
To unsubscribe, or for help writing mail filters, visit
https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I41b644c6841b222d1c6c529b2f9189f42178e28c
Gerrit-Change-Number: 4023
Gerrit-PatchSet: 13
Gerrit-Owner: Hussain Towaileb <[email protected]>
Gerrit-Reviewer: Ali Alsuliman <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin <[email protected]>
Gerrit-Reviewer: Hussain Towaileb <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-MessageType: newpatchset
