>From Dmitry Lychagin <[email protected]>: Dmitry Lychagin has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4023 )
Change subject: [ASTERIXDB-2667][FUN] Share code base between string functions ...................................................................... Patch Set 13: (2 comments) https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4023/13/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/PointableHelper.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/PointableHelper.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4023/13/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/PointableHelper.java@322 PS13, Line 322: if (listAccessor.getItemType() == ATypeTag.MISSING) { I'd move this into the else block of the next if statement: if (listAccessor.itemsAreSelfDescribing()) { ... } else if (listAccessor.getItemType() == ATypeTag.MISSING) {....} https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4023/13/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/PointableHelper.java@336 PS13, Line 336: if (typeTag == ATypeTag.NULL) { what about NULLs in the list? Seems inconsistent that they are not handled by this method. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4023 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I41b644c6841b222d1c6c529b2f9189f42178e28c Gerrit-Change-Number: 4023 Gerrit-PatchSet: 13 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Comment-Date: Tue, 26 Nov 2019 19:24:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
