>From Nam Duong <[email protected]>: Attention is currently required from: Wail Alkowaileet, Till Westmann. Nam Duong has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17295 )
Change subject: [NO ISSUE][FUN] Implement array_swap, array_move, array_bin_search ...................................................................... Patch Set 4: Code-Review+1 (3 comments) File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArrayBinarySearchDescriptor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17295/comment/7ee381fe_a94c0387 PS1, Line 1: package > We need to add the Apache license header to all files that don't have it. Ack https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17295/comment/9f0dc8d5_5116bce4 PS1, Line 13: import org.apache.asterix.om.types.*; > We should avoid "*" imports. […] Ack https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17295/comment/6b7da708_c6c4ea39 PS1, Line 137: // if found > Let's keep comments to 120 characters or less. Ack -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17295 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I2d526d90f04e62a3cc860775103254bd46d530b9 Gerrit-Change-Number: 17295 Gerrit-PatchSet: 4 Gerrit-Owner: Nam Duong <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Nam Duong <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-CC: Till Westmann <[email protected]> Gerrit-Attention: Wail Alkowaileet <[email protected]> Gerrit-Attention: Till Westmann <[email protected]> Gerrit-Comment-Date: Mon, 05 Dec 2022 11:26:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Till Westmann <[email protected]> Gerrit-MessageType: comment
