>From Wail Alkowaileet <[email protected]>: Attention is currently required from: Till Westmann, Nam Duong. Wail Alkowaileet has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17295 )
Change subject: [NO ISSUE][FUN] Implement array_swap, array_move, array_bin_search ...................................................................... Patch Set 4: (3 comments) Patchset: PS4: Ali brought up that we should restrict those functions to arrays and exclude multiset (Also known as unordered lists), which doesn't have a notion of "position" anyway. File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArrayBinarySearchDescriptor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17295/comment/0b8daf31_13071e31 PS4, Line 137: listType.isListType Let's restrict this function and also array_swap and array_move to arrays only -- i.e., Unordered list (multiset) should be excluded. File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArrayMoveDescriptor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17295/comment/af364141_0a857886 PS4, Line 160: AUnorderedListType We need only to consider arrays and exclude multiset -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17295 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I2d526d90f04e62a3cc860775103254bd46d530b9 Gerrit-Change-Number: 17295 Gerrit-PatchSet: 4 Gerrit-Owner: Nam Duong <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Nam Duong <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-CC: Till Westmann <[email protected]> Gerrit-Attention: Till Westmann <[email protected]> Gerrit-Attention: Nam Duong <[email protected]> Gerrit-Comment-Date: Mon, 05 Dec 2022 20:05:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
