Taewoo Kim has posted comments on this change. Change subject: ASTERIXDB-1778: Optimize the edit-distance-check function ......................................................................
Patch Set 3: (11 comments) @Jianfeng: Thanks! https://asterix-gerrit.ics.uci.edu/#/c/1481/4/asterixdb/asterix-fuzzyjoin/src/main/java/org/apache/asterix/fuzzyjoin/similarity/IGenericSimilarityMetric.java File asterixdb/asterix-fuzzyjoin/src/main/java/org/apache/asterix/fuzzyjoin/similarity/IGenericSimilarityMetric.java: PS4, Line 26: > use javadoc syntax? Done PS4, Line 29: float > this function doesn't has to be exposed. Done PS4, Line 32: returns > use javadoc? Done https://asterix-gerrit.ics.uci.edu/#/c/1481/2/asterixdb/asterix-fuzzyjoin/src/main/java/org/apache/asterix/fuzzyjoin/similarity/SimilarityMetric.java File asterixdb/asterix-fuzzyjoin/src/main/java/org/apache/asterix/fuzzyjoin/similarity/SimilarityMetric.java: Line 28: public static int getIntersectSize(ISequenceIterator tokensX, ISequenceIterator tokensY) > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/1481/3/asterixdb/asterix-fuzzyjoin/src/main/java/org/apache/asterix/fuzzyjoin/similarity/SimilarityMetricEditDistance.java File asterixdb/asterix-fuzzyjoin/src/main/java/org/apache/asterix/fuzzyjoin/similarity/SimilarityMetricEditDistance.java: PS3, Line 63: public > is it necessary to has an `public interface` ? Agreed and done. Line 70: boolean canTerminateEarly = edThresh >= 0 ? true : false; > *boolean canTerminateEarly = edThresh >= 0* is enough. The caller that is calling this function already checks your if condition.Since we change this to a private function, I think it's OK not to add the if condition. PS3, Line 131: 1 > can you define a static variable and give `-1` a good name? Done PS3, Line 144: Gets > do we really need this comments ? :-) Done PS3, Line 157: - > it worth explain the meaning of -1 Done PS3, Line 168: public > is it necessary to be a public method? Yes. It is being called from the outside of this class. PS3, Line 219: public > public -> private? It is being called from the outside. -- To view, visit https://asterix-gerrit.ics.uci.edu/1481 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc8729c4514bb87c347dd7d50358fd897b769977 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim <wangs...@gmail.com> Gerrit-Reviewer: Anon. E. Moose #1000151 Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Jianfeng Jia <jianfeng....@gmail.com> Gerrit-Reviewer: Steven Jacobs <sjaco...@ucr.edu> Gerrit-Reviewer: Taewoo Kim <wangs...@gmail.com> Gerrit-HasComments: Yes
