Anon. E. Moose #1000151 has posted comments on this change. Change subject: ASTERIXDB-1778: Optimize the edit-distance-check function ......................................................................
Patch Set 4: (5 comments) First set of comments https://asterix-gerrit.ics.uci.edu/#/c/1481/4/asterixdb/asterix-fuzzyjoin/src/main/java/org/apache/asterix/fuzzyjoin/similarity/IGenericSimilarityMetric.java File asterixdb/asterix-fuzzyjoin/src/main/java/org/apache/asterix/fuzzyjoin/similarity/IGenericSimilarityMetric.java: PS4, Line 29: float > this function doesn't has to be exposed. Is it better to rename "get" to "compute" since "get" seems to suggest it's a "getter"? https://asterix-gerrit.ics.uci.edu/#/c/1481/4/asterixdb/asterix-fuzzyjoin/src/main/java/org/apache/asterix/fuzzyjoin/similarity/SimilarityMetricEditDistance.java File asterixdb/asterix-fuzzyjoin/src/main/java/org/apache/asterix/fuzzyjoin/similarity/SimilarityMetricEditDistance.java: PS4, Line 49: lists "lists" -> "sequences" to be consistent with the parameter type? PS4, Line 51: entire cells "entire cells" -> "all the cells in the row" PS4, Line 53: less than "less than" -> "within"? Line 99: if (canTerminateEarly) { Where is this "canTerminateEarly" decided? I couldn't find it. -- To view, visit https://asterix-gerrit.ics.uci.edu/1481 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc8729c4514bb87c347dd7d50358fd897b769977 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim <wangs...@gmail.com> Gerrit-Reviewer: Anon. E. Moose #1000151 Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Jianfeng Jia <jianfeng....@gmail.com> Gerrit-Reviewer: Steven Jacobs <sjaco...@ucr.edu> Gerrit-Reviewer: Taewoo Kim <wangs...@gmail.com> Gerrit-HasComments: Yes
