>From Ali Alsuliman <[email protected]>: Attention is currently required from: Wail Alkowaileet. Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17995 )
Change subject: [ASTERIXDB-3324][STO][RT] Clossed types stabilization in columnar ...................................................................... Patch Set 1: Code-Review+2 (7 comments) File asterixdb/asterix-column/src/main/java/org/apache/asterix/column/bytes/decoder/ParquetPlainFixedLengthValuesReader.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17995/comment/af5cba3d_8659cc11 PS1, Line 66: double long? https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17995/comment/63b6324d_49bd548a PS1, Line 75: double float? File asterixdb/asterix-column/src/main/java/org/apache/asterix/column/bytes/encoder/ParquetPlainFixedLengthValuesWriter.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17995/comment/f113f45c_2277b1d5 PS1, Line 69: int float? File asterixdb/asterix-column/src/main/java/org/apache/asterix/column/metadata/schema/visitor/ColumnSupportedTypesValidator.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17995/comment/a672ce1a_7fca19a1 PS1, Line 48: ATypeTag.BIGINT, ATypeTag.FLOAT other INTs? File asterixdb/asterix-column/src/main/java/org/apache/asterix/column/values/reader/value/key/FloatKeyValueReader.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17995/comment/8d4e4873_a10727e8 PS1, Line 37: public double getDouble() { do you also want to implement getFloat()? File asterixdb/asterix-column/src/main/java/org/apache/asterix/column/values/reader/value/key/LongKeyValueReader.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17995/comment/96ca1f16_67b70ba3 PS1, Line 44: value the "value" we are reading here is always long (8 bytes)? File asterixdb/asterix-column/src/main/java/org/apache/asterix/column/values/writer/FloatColumnValuesWriter.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17995/comment/e2277ea4_bc746a35 PS1, Line 108: DoubleColumnFilterWriter DoubleColumnFilterWriter? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17995 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Idf5be82359f6fd2f9d80cf33b07b9248218c70cd Gerrit-Change-Number: 17995 Gerrit-PatchSet: 1 Gerrit-Owner: Wail Alkowaileet <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-Attention: Wail Alkowaileet <[email protected]> Gerrit-Comment-Date: Wed, 06 Dec 2023 00:14:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
