>From Wail Alkowaileet <[email protected]>: Attention is currently required from: Ali Alsuliman. Wail Alkowaileet has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17995 )
Change subject: [ASTERIXDB-3324][STO][RT] Clossed types stabilization in columnar ...................................................................... Patch Set 1: (8 comments) Patchset: PS1: I'll address the comments in a follow-up change File asterixdb/asterix-column/src/main/java/org/apache/asterix/column/bytes/decoder/ParquetPlainFixedLengthValuesReader.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17995/comment/f6760450_65f4163c PS1, Line 66: double > long? Yes https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17995/comment/dcd91bc4_ffaa6bcf PS1, Line 75: double > float? Yes File asterixdb/asterix-column/src/main/java/org/apache/asterix/column/bytes/encoder/ParquetPlainFixedLengthValuesWriter.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17995/comment/a5ab4b4f_423512ae PS1, Line 69: int > float? Yes File asterixdb/asterix-column/src/main/java/org/apache/asterix/column/metadata/schema/visitor/ColumnSupportedTypesValidator.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17995/comment/8d231a83_9e04c16c PS1, Line 48: ATypeTag.BIGINT, ATypeTag.FLOAT > other INTs? We normalize the values for other INTs. We cannot do the same for float because conversion produces weird numbers. File asterixdb/asterix-column/src/main/java/org/apache/asterix/column/values/reader/value/key/FloatKeyValueReader.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17995/comment/cbcb387c_1fa5ffe9 PS1, Line 37: public double getDouble() { > do you also want to implement getFloat()? Yes! Good catch File asterixdb/asterix-column/src/main/java/org/apache/asterix/column/values/reader/value/key/LongKeyValueReader.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17995/comment/cd13e13e_7cd73fec PS1, Line 44: value > the "value" we are reading here is always long (8 bytes)? Yes. We always use 8-bytes here (normalized) File asterixdb/asterix-column/src/main/java/org/apache/asterix/column/values/writer/FloatColumnValuesWriter.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17995/comment/071a6359_b969e363 PS1, Line 108: DoubleColumnFilterWriter > DoubleColumnFilterWriter? I'm using double filters as both min/max values are normalized to 8-bytes long values. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17995 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Idf5be82359f6fd2f9d80cf33b07b9248218c70cd Gerrit-Change-Number: 17995 Gerrit-PatchSet: 1 Gerrit-Owner: Wail Alkowaileet <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Comment-Date: Wed, 06 Dec 2023 00:24:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ali Alsuliman <[email protected]> Gerrit-MessageType: comment
