abdullah alamoudi has posted comments on this change. Change subject: Feed Connection Refactoring ......................................................................
Patch Set 14: (33 comments) https://asterix-gerrit.ics.uci.edu/#/c/1259/14/asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActivityState.java File asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActivityState.java: PS14, Line 21: ActivityState > Could this remain an enum? Done https://asterix-gerrit.ics.uci.edu/#/c/1259/14/asterixdb/asterix-active/src/main/java/org/apache/asterix/active/IActiveEntityEventsListener.java File asterixdb/asterix-active/src/main/java/org/apache/asterix/active/IActiveEntityEventsListener.java: PS14, Line 40: byte > This would be nicer, if the state were an enum. On the interface it's not c Done https://asterix-gerrit.ics.uci.edu/#/c/1259/14/asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/FeedOperations.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/FeedOperations.java: Line 158: PrintWriter writer = new PrintWriter(System.err, true); > Indeed. Why do we write to System.err here? Done https://asterix-gerrit.ics.uci.edu/#/c/1259/14/asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feeds_02/feeds_02.2.update.aql File asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feeds_02/feeds_02.2.update.aql: PS14, Line 20: > Fix the WS? Done PS14, Line 21: > WS? Done https://asterix-gerrit.ics.uci.edu/#/c/1259/14/asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feeds_03/feeds_03.1.ddl.aql File asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feeds_03/feeds_03.1.ddl.aql: PS14, Line 36: > WS? Done https://asterix-gerrit.ics.uci.edu/#/c/1259/14/asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feeds_07/feeds_07.2.update.aql File asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feeds_07/feeds_07.2.update.aql: PS14, Line 20: > WS Done PS14, Line 29: > WS Done https://asterix-gerrit.ics.uci.edu/#/c/1259/14/asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feeds_08/feeds_08.2.update.aql File asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feeds_08/feeds_08.2.update.aql: PS14, Line 31: > WS Done https://asterix-gerrit.ics.uci.edu/#/c/1259/14/asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feeds_09/feeds_09.2.update.aql File asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feeds_09/feeds_09.2.update.aql: PS14, Line 20: > WS Done PS14, Line 29: > WS Done https://asterix-gerrit.ics.uci.edu/#/c/1259/14/asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feeds_10/feeds_10.2.update.aql File asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feeds_10/feeds_10.2.update.aql: PS14, Line 28: > WS Done https://asterix-gerrit.ics.uci.edu/#/c/1259/14/asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feeds_11/feeds_11.2.update.aql File asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feeds_11/feeds_11.2.update.aql: PS14, Line 20: > WS Done PS14, Line 21: > WS Done PS14, Line 29: > WS Done https://asterix-gerrit.ics.uci.edu/#/c/1259/14/asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feeds_12/feeds_12.2.update.aql File asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feeds_12/feeds_12.2.update.aql: PS14, Line 20: > WS Done PS14, Line 21: > WS Done PS14, Line 29: > WS Done https://asterix-gerrit.ics.uci.edu/#/c/1259/14/asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/issue_230_feeds/issue_230_feeds.2.update.aql File asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/issue_230_feeds/issue_230_feeds.2.update.aql: PS14, Line 20: > WS Done PS14, Line 21: > WS Done PS14, Line 29: > WS Done https://asterix-gerrit.ics.uci.edu/#/c/1259/14/asterixdb/asterix-app/src/test/resources/runtimets/queries/hints/issue_251_dataset_hint_7/issue_251_dataset_hint_7.2.update.aql File asterixdb/asterix-app/src/test/resources/runtimets/queries/hints/issue_251_dataset_hint_7/issue_251_dataset_hint_7.2.update.aql: PS14, Line 20: > WS Done PS14, Line 22: > WS Done https://asterix-gerrit.ics.uci.edu/#/c/1259/14/asterixdb/asterix-installer/src/test/resources/integrationts/library/queries/library-adapters/typed_adapter/typed_adapter.2.update.aql File asterixdb/asterix-installer/src/test/resources/integrationts/library/queries/library-adapters/typed_adapter/typed_adapter.2.update.aql: PS14, Line 22: > WS Done PS14, Line 23: > WS Done https://asterix-gerrit.ics.uci.edu/#/c/1259/14/asterixdb/asterix-installer/src/test/resources/integrationts/library/queries/library-feeds/feed_ingest/feed_ingest.2.update.aql File asterixdb/asterix-installer/src/test/resources/integrationts/library/queries/library-feeds/feed_ingest/feed_ingest.2.update.aql: PS14, Line 22: > WS Done PS14, Line 23: > WS Done https://asterix-gerrit.ics.uci.edu/#/c/1259/14/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataCache.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataCache.java: PS14, Line 32: .*; > Restore the imports here. Done https://asterix-gerrit.ics.uci.edu/#/c/1259/14/asterixdb/asterix-yarn/src/test/resources/library/queries/library-adapters/typed_adapter/typed_adapter.2.update.aql File asterixdb/asterix-yarn/src/test/resources/library/queries/library-adapters/typed_adapter/typed_adapter.2.update.aql: PS14, Line 22: > WS Done PS14, Line 23: > WS Done https://asterix-gerrit.ics.uci.edu/#/c/1259/14/asterixdb/asterix-yarn/src/test/resources/library/queries/library-feeds/feed_ingest/feed_ingest.1.ddl.aql File asterixdb/asterix-yarn/src/test/resources/library/queries/library-feeds/feed_ingest/feed_ingest.1.ddl.aql: PS14, Line 53: ) > WS Done https://asterix-gerrit.ics.uci.edu/#/c/1259/14/asterixdb/asterix-yarn/src/test/resources/library/queries/library-feeds/feed_ingest/feed_ingest.2.update.aql File asterixdb/asterix-yarn/src/test/resources/library/queries/library-feeds/feed_ingest/feed_ingest.2.update.aql: PS14, Line 22: > WS Done PS14, Line 23: > WS Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1259 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic36267eb9a10df21734ce1cc1f38583e23c9e8f0 Gerrit-PatchSet: 14 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang <xkk...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Steven Jacobs <sjaco...@ucr.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Xikui Wang <xkk...@gmail.com> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
