Till Westmann has posted comments on this change. Change subject: Feed Connection Refactoring ......................................................................
Patch Set 15: (1 comment) Changes between 14 and 15 look good to me, just one long line in FeedOperations ... https://asterix-gerrit.ics.uci.edu/#/c/1259/15/asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/FeedOperations.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/FeedOperations.java: Line 148: org.apache.hyracks.algebricks.common.utils.Pair<IFileSplitProvider, AlgebricksPartitionConstraint> splitsAndConstraint = > MAJOR SonarQube violation: indeed. -- To view, visit https://asterix-gerrit.ics.uci.edu/1259 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic36267eb9a10df21734ce1cc1f38583e23c9e8f0 Gerrit-PatchSet: 15 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang <xkk...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Steven Jacobs <sjaco...@ucr.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Xikui Wang <xkk...@gmail.com> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
