>From Wail Alkowaileet <[email protected]>: Attention is currently required from: Murtadha Hubail, Peeyush Gupta, Janhavi Tripurwar, Ali Alsuliman, Michael Blow. Wail Alkowaileet has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18385 )
Change subject: [ASTERIXDB-3444][COMP] Add put-autogenerated-key() function ...................................................................... Patch Set 8: (4 comments) File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceAutogenerateIDRule.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18385/comment/4d65de7a_95d2a746 PS8, Line 199: keyName Do we really need to handle this case for auto-generated keys? I think it is reasonable to enforce auto-generated keys to be top-level fields. File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/PutAutogeneratedKeyEvaluator.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18385/comment/ba4e5c74_42c4f29b PS8, Line 98: inRecPointable Do we need to check if the result here is of type OBJECT? https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18385/comment/67d82470_ac0277b5 PS8, Line 147: addAutogeneratedKey This might add a key to the wrong nested child? { x: {...}, y: {..., myKey: uuid} } 'x' will be visited before 'y', and both are at the same level It might be easier to follow they key path, level by level. ROOT.y.myKey. If we are in 'y', then add the key if it does not exist. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18385/comment/b164e488_02149059 PS8, Line 177: combinedType != null Is this possible to be null? nested keys should enforce the parents' types to be in the closed part. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18385 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I54cc2fe65d7a5d2534a2c5b9a2fb6de5448ddc98 Gerrit-Change-Number: 18385 Gerrit-PatchSet: 8 Gerrit-Owner: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Janhavi Tripurwar <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Attention: Janhavi Tripurwar <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Attention: Michael Blow <[email protected]> Gerrit-Comment-Date: Sun, 23 Jun 2024 17:34:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
