>From Ali Alsuliman <[email protected]>: Attention is currently required from: Murtadha Hubail, Peeyush Gupta, Wail Alkowaileet, Janhavi Tripurwar, Michael Blow. Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18385 )
Change subject: [ASTERIXDB-3444][COMP] Add put-autogenerated-key() function ...................................................................... Patch Set 9: Code-Review+1 (4 comments) File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceAutogenerateIDRule.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18385/comment/389274d5_c0f98ff3 PS8, Line 199: keyName > Do we really need to handle this case for auto-generated keys? I think it is > reasonable to enforce a […] Let's discuss this at a wider group. File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/PutAutogeneratedKeyEvaluator.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18385/comment/160ee836_5b954e86 PS8, Line 98: inRecPointable > Do we need to check if the result here is of type OBJECT? Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18385/comment/958f2def_0f8c5540 PS8, Line 147: addAutogeneratedKey > This might add a key to the wrong nested child? […] It should be fine since it starts visiting at the root already. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18385/comment/2b0f3aae_0a1d9c49 PS8, Line 177: combinedType != null > Is this possible to be null? nested keys should enforce the parents' types to > be in the closed part. Removed. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18385 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I54cc2fe65d7a5d2534a2c5b9a2fb6de5448ddc98 Gerrit-Change-Number: 18385 Gerrit-PatchSet: 9 Gerrit-Owner: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Janhavi Tripurwar <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Attention: Wail Alkowaileet <[email protected]> Gerrit-Attention: Janhavi Tripurwar <[email protected]> Gerrit-Attention: Michael Blow <[email protected]> Gerrit-Comment-Date: Mon, 24 Jun 2024 21:43:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Wail Alkowaileet <[email protected]> Gerrit-MessageType: comment
