>From Ali Alsuliman <[email protected]>: Attention is currently required from: Peeyush Gupta. Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20135 )
Change subject: [ASTERIXDB-3633][EXT] Support file splits while reading delta tables ...................................................................... Patch Set 7: (2 comments) File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/aws/delta/DeltaFileRecordReader.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20135/comment/a7d62036_16bbd447 PS7, Line 112: DeltaFileRecordReader Minor; could we refactor common parts and call these constructors to a single private constructor? File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/aws/delta/SerializableFileSplit.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20135/comment/5b1061d9_ec5c49d5 PS7, Line 49: dos.close(); Minor; could we use try-with resources? or? same below. Have you looked at JavaSerializationUtils and whether we can re-use what's there? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20135 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: ionic Gerrit-Change-Id: Ie6daf3846064326bfe749ad15b508fe27d1721ca Gerrit-Change-Number: 20135 Gerrit-PatchSet: 7 Gerrit-Owner: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-CC: Michael Blow <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Comment-Date: Mon, 25 Aug 2025 22:03:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
