>From Michael Blow <[email protected]>:

Attention is currently required from: Peeyush Gupta, Ali Alsuliman.
Michael Blow has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20135 )

Change subject: [ASTERIXDB-3633][EXT] Support file splits while reading delta 
tables
......................................................................


Patch Set 9:

(1 comment)

File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/aws/delta/DeltaReaderFactory.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20135/comment/ed00e523_858b7994
PS7, Line 192: FileSplit
> Did not quite understand your comment. […]
Doesn't need to be an anonymous class, couldn't you update 
SerializableFileSplit to extend this FileSplit, and just create the 
SerializableFileSplit here, then you could use the FileSplit naturally in your 
serialized plan without having to do the marshal/unmarshal from the 
SerializableFileSplit?



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20135
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: ionic
Gerrit-Change-Id: Ie6daf3846064326bfe749ad15b508fe27d1721ca
Gerrit-Change-Number: 20135
Gerrit-PatchSet: 9
Gerrit-Owner: Peeyush Gupta <[email protected]>
Gerrit-Reviewer: Ali Alsuliman <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Peeyush Gupta <[email protected]>
Gerrit-CC: Michael Blow <[email protected]>
Gerrit-Attention: Peeyush Gupta <[email protected]>
Gerrit-Attention: Ali Alsuliman <[email protected]>
Gerrit-Comment-Date: Tue, 26 Aug 2025 22:42:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Peeyush Gupta <[email protected]>
Comment-In-Reply-To: Michael Blow <[email protected]>
Gerrit-MessageType: comment

Reply via email to