>From Ali Alsuliman <ali.al.solai...@gmail.com>:

Attention is currently required from: Peeyush Gupta, Michael Blow.
Ali Alsuliman has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20135 )

Change subject: [ASTERIXDB-3633][EXT] Support file splits while reading delta 
tables
......................................................................


Patch Set 10: Code-Review+2

(1 comment)

File 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/DatasetDataSource.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20135/comment/237c5163_ca90b6e0
PS10, Line 143: setExternalCollectionCompilerProperties(metadataProvider, 
properties);
You can address this in a follow-on change. See the comment in 
addExternalProjectionInfo about the properties being cached (across queries). 
It might be just simpler to always make a copy of the edd.properties first and 
then make the modifications.



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20135
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: ionic
Gerrit-Change-Id: Ie6daf3846064326bfe749ad15b508fe27d1721ca
Gerrit-Change-Number: 20135
Gerrit-PatchSet: 10
Gerrit-Owner: Peeyush Gupta <peeyush.gu...@couchbase.com>
Gerrit-Reviewer: Ali Alsuliman <ali.al.solai...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Peeyush Gupta <peeyush.gu...@couchbase.com>
Gerrit-CC: Michael Blow <mb...@apache.org>
Gerrit-Attention: Peeyush Gupta <peeyush.gu...@couchbase.com>
Gerrit-Attention: Michael Blow <mb...@apache.org>
Gerrit-Comment-Date: Wed, 27 Aug 2025 16:13:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to