>From Hussain Towaileb <[email protected]>: Attention is currently required from: Michael Blow.
Hussain Towaileb has posted comments on this change by Hussain Towaileb. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20428?usp=email ) Change subject: [ASTERIXDB-3653][EXT]: Properly handle errors when deleting for COPY TO ...................................................................... Patch Set 2: Code-Review+1 (4 comments) File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/aws/s3/S3CloudClient.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20428/comment/8812a8ed_b4987672?usp=email : PS1, Line 250: s3Client.deleteObject(request); > we should wrap any exceptions in HDE so that they are checked exceptions Done File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/azure/blobstorage/AzBlobStorageCloudClient.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20428/comment/6c9a8994_984e52c7?usp=email : PS1, Line 269: blobClient.delete(); > don't you want `deleteWithResponse` and check the status code? deleteWithResponse seems to always take a parameter to delete the snapshots of a blob as well, will need to look more into that before using it. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20428/comment/b826b4bf_710f6b62?usp=email : PS1, Line 293: LOGGER.warn("Failed to delete blob: {} with status code: {} while deleting {}", deletedPath, > unrelated to this change, but shouldn't we be throwing an exception if we > failed to delete one or mo […] You're right, done. File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/google/gcs/GCSCloudClient.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20428/comment/6699c1db_ae0a3c6e?usp=email : PS1, Line 213: gcsClient.delete(blobId); > shouldn't we be wrapping any Exception into a HDE so that it is checked? Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20428?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: phoenix Gerrit-Change-Id: Ib670a014a5e4378b0a63be740ead72d699a84bb1 Gerrit-Change-Number: 20428 Gerrit-PatchSet: 2 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Michael Blow <[email protected]> Gerrit-Attention: Michael Blow <[email protected]> Gerrit-Comment-Date: Wed, 01 Oct 2025 02:48:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Michael Blow <[email protected]>
