>From Michael Blow <[email protected]>: Attention is currently required from: Hussain Towaileb.
Michael Blow has posted comments on this change by Hussain Towaileb. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20428?usp=email ) Change subject: [ASTERIXDB-3653][EXT]: Properly handle errors when deleting for COPY TO ...................................................................... Patch Set 1: (4 comments) File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/aws/s3/S3CloudClient.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20428/comment/c7d4c2d8_c2cafbc3?usp=email : PS1, Line 250: s3Client.deleteObject(request); we should wrap any exceptions in HDE so that they are checked exceptions File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/azure/blobstorage/AzBlobStorageCloudClient.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20428/comment/0336cd42_b21ab04e?usp=email : PS1, Line 269: blobClient.delete(); don't you want `deleteWithResponse` and check the status code? https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20428/comment/f5594477_e0d0bdc8?usp=email : PS1, Line 293: LOGGER.warn("Failed to delete blob: {} with status code: {} while deleting {}", deletedPath, unrelated to this change, but shouldn't we be throwing an exception if we failed to delete one or more blobs, perhaps after iterating through the responses? File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/google/gcs/GCSCloudClient.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20428/comment/2e7811a7_a50f5cb1?usp=email : PS1, Line 213: gcsClient.delete(blobId); shouldn't we be wrapping any Exception into a HDE so that it is checked? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20428?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: phoenix Gerrit-Change-Id: Ib670a014a5e4378b0a63be740ead72d699a84bb1 Gerrit-Change-Number: 20428 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Michael Blow <[email protected]> Gerrit-Attention: Hussain Towaileb <[email protected]> Gerrit-Comment-Date: Tue, 30 Sep 2025 18:32:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
