>From Ali Alsuliman <[email protected]>: Attention is currently required from: Ritik Raj.
Ali Alsuliman has posted comments on this change by Ritik Raj. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20513?usp=email ) Change subject: [NO ISSUE][CLOUD] Use Azure async parallel downloader APIs ...................................................................... Patch Set 4: (6 comments) File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/azure/blobstorage/AzBlobStorageClientConfig.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20513/comment/d7c96ca3_86b20df3?usp=email : PS4, Line 57: 1000, 10000, 120); Let's define constants in CloudProperties and replace in all 3 places including the CloudProperties. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20513/comment/0eb4d3b5_51b31528?usp=email : PS4, Line 76: this.requestsMaxHttpConnections = requestsMaxHttpConnections; Ensure these are not <= 0 since your logic in some places assumes that they are > 0. File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/azure/blobstorage/AzureParallelDownloader.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20513/comment/69495218_fbb13ac1?usp=email : PS4, Line 101: .flatMap(mono -> mono, maxConcurrent > 0 ? maxConcurrent : downloads.size()).then().block()); Can we change this to downloads.size()? https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20513/comment/b654c5d3_17162573?usp=email : PS4, Line 110: Using config.getRequestsMaxPendingHttpConnections() for each directory means we could go beyond the concurrency of config.getRequestsMaxPendingHttpConnections() in total, right? https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20513/comment/11a1e6cb_ac8727e4?usp=email : PS4, Line 148: // System.err.println("Failed to download blob: " + blobItem.getName() + " -> " + error); Can we fix this? https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20513/comment/7b6acedc_df1181dc?usp=email : PS4, Line 197: Throwable cause = e.getCause(); Use ExceptionUtils.causedByInterrupt(e) then interrupt and then just throw HyracksDataException.create(e); -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20513?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: phoenix Gerrit-Change-Id: Iaab692c8d70019175738fdb39699796cf9ef72b8 Gerrit-Change-Number: 20513 Gerrit-PatchSet: 4 Gerrit-Owner: Ritik Raj <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Ali Alsuliman <[email protected]> Gerrit-Attention: Ritik Raj <[email protected]> Gerrit-Comment-Date: Fri, 24 Oct 2025 16:58:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
