>From Ritik Raj <[email protected]>: Attention is currently required from: Ali Alsuliman.
Ritik Raj has posted comments on this change by Ritik Raj. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20513?usp=email ) Change subject: [NO ISSUE][CLOUD] Use Azure async parallel downloader APIs ...................................................................... Patch Set 5: (5 comments) File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/azure/blobstorage/AzBlobStorageClientConfig.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20513/comment/1dbc376c_75a427f1?usp=email : PS4, Line 57: 1000, 10000, 120); > Let's define constants in CloudProperties and replace in all 3 places > including the CloudProperties. Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20513/comment/0115039c_00a7928e?usp=email : PS4, Line 76: this.requestsMaxHttpConnections = requestsMaxHttpConnections; > Ensure these are not <= 0 since your logic in some places assumes that they > are > 0. Done File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/azure/blobstorage/AzureParallelDownloader.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20513/comment/85cec912_d9e16bab?usp=email : PS4, Line 101: .flatMap(mono -> mono, maxConcurrent > 0 ? maxConcurrent : downloads.size()).then().block()); > Can we change this to downloads. […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20513/comment/465e4567_560835c0?usp=email : PS4, Line 148: // System.err.println("Failed to download blob: " + blobItem.getName() + " -> " + error); > Can we fix this? Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20513/comment/b51c88be_4795cc85?usp=email : PS4, Line 197: Throwable cause = e.getCause(); > Use ExceptionUtils.causedByInterrupt(e) then interrupt and then just throw > HyracksDataException. […] Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20513?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: phoenix Gerrit-Change-Id: Iaab692c8d70019175738fdb39699796cf9ef72b8 Gerrit-Change-Number: 20513 Gerrit-PatchSet: 5 Gerrit-Owner: Ritik Raj <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Ali Alsuliman <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Comment-Date: Fri, 24 Oct 2025 19:13:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ali Alsuliman <[email protected]>
