>From Michael Blow <[email protected]>: Attention is currently required from: Ian Maxon, Shahrzad Shirazi.
Michael Blow has posted comments on this change by Shahrzad Shirazi. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20490?usp=email ) Change subject: [ASTERIXDB-3658][COMP] Fix serialization error in query with many selected fields ...................................................................... Patch Set 9: (2 comments) File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/profiling/IOperatorStats.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20490/comment/624ba6b9_086adf32?usp=email : PS9, Line 52: ICounter getPageReads(); let's pick and stick with a convention- the existing accessors are `get...Counter()`, for the new ones we have `...Counter()` `get...()`, etc. Let's keep these all named `get...Counter()` File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/profiling/OperatorStats.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20490/comment/1db47894_81ba8a5a?usp=email : PS9, Line 219: tupleCounter.set(input.readLong()); when do we read the operator name & operator id we write in writeFields? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20490?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: If165897ba45cc685cd85258c1167a7252996666f Gerrit-Change-Number: 20490 Gerrit-PatchSet: 9 Gerrit-Owner: Shahrzad Shirazi <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Michael Blow <[email protected]> Gerrit-CC: Murtadha Hubail <[email protected]> Gerrit-CC: shahrzadshirazi <[email protected]> Gerrit-Attention: Shahrzad Shirazi <[email protected]> Gerrit-Attention: Ian Maxon <[email protected]> Gerrit-Comment-Date: Wed, 05 Nov 2025 15:42:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
