>From Ian Maxon <[email protected]>: Attention is currently required from: Michael Blow, Shahrzad Shirazi.
Ian Maxon has posted comments on this change by Shahrzad Shirazi. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20490?usp=email ) Change subject: [ASTERIXDB-3658][COMP] Fix serialization error in query with many selected fields ...................................................................... Patch Set 11: (3 comments) Commit Message: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20490/comment/b53aae71_7a7d8963?usp=email : PS9, Line 14: > I see the `Ext-ref` is removed, is there no Couchbase ticket tracking this > issue? i guess i can add it, but this fix is different than the others under that ref, so i didn't want to confuse the two File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/profiling/IOperatorStats.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20490/comment/4253664d_289595bf?usp=email : PS9, Line 52: ICounter getPageReads(); > let's pick and stick with a convention- the existing accessors are `get... […] sure, i changed this one, do you want to change all of them? frankly i think this class needs to change into something like Map<CounterName,ICounter> where CounterName is an enum. File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/profiling/OperatorStats.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20490/comment/b41701fa_cc78a153?usp=email : PS9, Line 219: tupleCounter.set(input.readLong()); > when do we read the operator name & operator id we write in writeFields? it gets read in IOperatorStats::create, which calls this to read the rest of the fields -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20490?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: If165897ba45cc685cd85258c1167a7252996666f Gerrit-Change-Number: 20490 Gerrit-PatchSet: 11 Gerrit-Owner: Shahrzad Shirazi <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Michael Blow <[email protected]> Gerrit-CC: Murtadha Hubail <[email protected]> Gerrit-CC: shahrzadshirazi <[email protected]> Gerrit-Attention: Shahrzad Shirazi <[email protected]> Gerrit-Attention: Michael Blow <[email protected]> Gerrit-Comment-Date: Wed, 05 Nov 2025 16:18:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Blow <[email protected]>
