>From Michael Blow <[email protected]>:

Attention is currently required from: Ian Maxon, Shahrzad Shirazi.

Michael Blow has posted comments on this change by Shahrzad Shirazi. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20490?usp=email )

Change subject: [ASTERIXDB-3658][COMP] Fix serialization error in query with 
many selected fields
......................................................................


Patch Set 12: Code-Review+2

(1 comment)

File 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/profiling/OperatorStats.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20490/comment/70833c27_668f33fb?usp=email
 :
PS9, Line 219:         tupleCounter.set(input.readLong());
> it gets read in IOperatorStats::create, which calls this to read the rest of 
> the fields
ok, I confess I don't love that "readFields" and "writeFields" aren't 
reciprocal, but at least I grok it now.



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20490?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: If165897ba45cc685cd85258c1167a7252996666f
Gerrit-Change-Number: 20490
Gerrit-PatchSet: 12
Gerrit-Owner: Shahrzad Shirazi <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Michael Blow <[email protected]>
Gerrit-CC: Murtadha Hubail <[email protected]>
Gerrit-CC: shahrzadshirazi <[email protected]>
Gerrit-Attention: Shahrzad Shirazi <[email protected]>
Gerrit-Attention: Ian Maxon <[email protected]>
Gerrit-Comment-Date: Fri, 07 Nov 2025 03:50:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Ian Maxon <[email protected]>
Comment-In-Reply-To: Michael Blow <[email protected]>

Reply via email to