>From Ali Alsuliman <[email protected]>: Attention is currently required from: Michael Blow.
Ali Alsuliman has posted comments on this change by Michael Blow. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20568?usp=email ) Change subject: [NO ISSUE][*DB][STO] Enable round/robin dns resolution for async client ...................................................................... Patch Set 2: Code-Review+2 (3 comments) File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/aws/s3/RoundRobinAddressResolverGroup.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20568/comment/73fb2ff6_5fbd6253?usp=email : PS2, Line 53: List<InetSocketAddress> all = resolveAllSync(unresolved); Mike usually does not create new ArrayList only to get one element out of it, but he might also tell me there will be JIT optimizations or maybe not worth the optimization. File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/aws/s3/S3ClientConfig.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20568/comment/5955154c_768feb61?usp=email : PS2, Line 207: public boolean useRoundRobinDnsResolver() { Do you want the naming of isUseNonBlockingDnsResolver and useRoundRobinDnsResolver to be consistent? or you don't feel like it? File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/CloudProperties.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20568/comment/9ab6ba3c_e010a2bc?usp=email : PS2, Line 344: public boolean isUseRoundRobinDnsResolver() { If you are making changes to the naming of the other two, then you might also want to make this consistent with them. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20568?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: phoenix Gerrit-Change-Id: I93fce9317774b368965f224179ca177dfbf0a45c Gerrit-Change-Number: 20568 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Blow <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Attention: Michael Blow <[email protected]> Gerrit-Comment-Date: Fri, 14 Nov 2025 00:17:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
