>From Michael Blow <[email protected]>: Attention is currently required from: Ali Alsuliman.
Michael Blow has posted comments on this change by Michael Blow. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20568?usp=email ) Change subject: [NO ISSUE][*DB][STO] Enable round/robin dns resolution for async client ...................................................................... Patch Set 2: Code-Review+1 (3 comments) File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/aws/s3/RoundRobinAddressResolverGroup.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20568/comment/08645c24_9a4ddfa2?usp=email : PS2, Line 53: List<InetSocketAddress> all = resolveAllSync(unresolved); > Mike usually does not create new ArrayList only to get one element out of it, > but he might also tell […] Apparently co-pilot doesn't go by "Mike" File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/aws/s3/S3ClientConfig.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20568/comment/c922e288_ab7e1ff3?usp=email : PS2, Line 207: public boolean useRoundRobinDnsResolver() { > Do you want the naming of isUseNonBlockingDnsResolver and > useRoundRobinDnsResolver to be consistent? […] Done File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/CloudProperties.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20568/comment/2945e71e_7ddccbca?usp=email : PS2, Line 344: public boolean isUseRoundRobinDnsResolver() { > If you are making changes to the naming of the other two, then you might also > want to make this cons […] Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20568?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: phoenix Gerrit-Change-Id: I93fce9317774b368965f224179ca177dfbf0a45c Gerrit-Change-Number: 20568 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Blow <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Comment-Date: Fri, 14 Nov 2025 12:59:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Ali Alsuliman <[email protected]>
