>From Ali Alsuliman <[email protected]>: Attention is currently required from: Janhavi Tripurwar, Peeyush Gupta, Preetham Poluparthi.
Ali Alsuliman has posted comments on this change by Janhavi Tripurwar. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20572?usp=email ) Change subject: [ASTERIXDB-3673]: Fix: Prevent CBO failure when samples are empty ...................................................................... Patch Set 4: (5 comments) File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/EnumerateJoinsRule.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20572/comment/fee88acf_28127286?usp=email : PS4, Line 1627: double sampleCard = Math.min(idxDetails.getSampleCardinalityTarget(), origDatasetCard); Isn't this always going to be origDatasetCard because it's 0 and idxDetails.getSampleCardinalityTarget() should always be > 0? File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/OperatorUtils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20572/comment/c70a1195_e29b6459?usp=email : PS4, Line 330: protected static void issueWarning(double sampleCard, DataSourceScanOperator scanOp, IOptimizationContext optCtx) { Move it to ExceptionUtil and rename it warnEmptySamples https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20572/comment/2e700b9d_505aeee1?usp=email : PS4, Line 330: protected static void issueWarning(double sampleCard, DataSourceScanOperator scanOp, IOptimizationContext optCtx) { Pass the SourceLocation srcLoc instead of passing the operator https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20572/comment/2f708b6f_cee25ce4?usp=email : PS4, Line 332: sampleCard = 1; What is this sampleCard = 1; for? Remove it if not needed. File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/Stats.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20572/comment/1b58f02f_eda894ba?usp=email : PS4, Line 672: OperatorUtils.issueWarning(sampleCard, scanOp, optCtx); Remove the now unused issueWarning method from this class. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20572?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Iad996433d22308f8f4096e30a0b04be27c58c020 Gerrit-Change-Number: 20572 Gerrit-PatchSet: 4 Gerrit-Owner: Janhavi Tripurwar <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Janhavi Tripurwar <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Preetham Poluparthi <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Attention: Janhavi Tripurwar <[email protected]> Gerrit-Attention: Preetham Poluparthi <[email protected]> Gerrit-Comment-Date: Sun, 16 Nov 2025 15:31:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
