>From Janhavi Tripurwar <[email protected]>: Attention is currently required from: Ali Alsuliman, Peeyush Gupta, Preetham Poluparthi.
Janhavi Tripurwar has posted comments on this change by Janhavi Tripurwar. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20572?usp=email ) Change subject: [ASTERIXDB-3673]: Fix: Prevent CBO failure when samples are empty ...................................................................... Patch Set 6: Verified+1 (5 comments) File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/EnumerateJoinsRule.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20572/comment/ca9e590c_bdf23610?usp=email : PS4, Line 1627: double sampleCard = Math.min(idxDetails.getSampleCardinalityTarget(), origDatasetCard); > Isn't this always going to be origDatasetCard because it's 0 and idxDetails. > […] Yes, updated. File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/OperatorUtils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20572/comment/53c2a308_330544aa?usp=email : PS4, Line 330: protected static void issueWarning(double sampleCard, DataSourceScanOperator scanOp, IOptimizationContext optCtx) { > Move it to ExceptionUtil and rename it warnEmptySamples Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20572/comment/29feae9a_a91fcbe0?usp=email : PS4, Line 330: protected static void issueWarning(double sampleCard, DataSourceScanOperator scanOp, IOptimizationContext optCtx) { > Pass the SourceLocation srcLoc instead of passing the operator Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20572/comment/1546d757_de8af354?usp=email : PS4, Line 332: sampleCard = 1; > What is this sampleCard = 1; for? Remove it if not needed. not needed, removed. File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/Stats.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20572/comment/08c770eb_1d73a199?usp=email : PS4, Line 672: OperatorUtils.issueWarning(sampleCard, scanOp, optCtx); > Remove the now unused issueWarning method from this class. Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20572?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Iad996433d22308f8f4096e30a0b04be27c58c020 Gerrit-Change-Number: 20572 Gerrit-PatchSet: 6 Gerrit-Owner: Janhavi Tripurwar <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Janhavi Tripurwar <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Preetham Poluparthi <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Attention: Preetham Poluparthi <[email protected]> Gerrit-Comment-Date: Sun, 16 Nov 2025 18:06:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Ali Alsuliman <[email protected]>
