>From Peeyush Gupta <[email protected]>: Attention is currently required from: Hussain Towaileb.
Peeyush Gupta has posted comments on this change by Hussain Towaileb. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20648?usp=email ) Change subject: [ASTERIXDB-3634][EXT]: Add support to Iceberg pt.3 ...................................................................... Patch Set 4: (3 comments) File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/IcebergParquetDataParser.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20648/comment/52478d71_39743232?usp=email : PS4, Line 314: LocalDate localDate = (LocalDate) value; Please check if the value here is local date or long both when the date field is top level field or nested field https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20648/comment/731a107b_8a571f4f?usp=email : PS4, Line 320: LocalTime localTime = (LocalTime) value; same as the previous comment https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20648/comment/9daa940c_22ef24bb?usp=email : PS4, Line 346: case FLOAT -> ATypeTag.FLOAT; ATypeTag.Float is returned here but it is serialized as double in the earler part of the code. Please check if this can cause any issues. If yes either return Double here or serialize as float. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20648?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I1726c2168bfec1f137390c7c2112c2df59151dc2 Gerrit-Change-Number: 20648 Gerrit-PatchSet: 4 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Attention: Hussain Towaileb <[email protected]> Gerrit-Comment-Date: Tue, 16 Dec 2025 19:23:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
