>From Hussain Towaileb <[email protected]>: Attention is currently required from: Peeyush Gupta.
Hussain Towaileb has posted comments on this change by Hussain Towaileb. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20648?usp=email ) Change subject: [ASTERIXDB-3634][EXT]: Add support to Iceberg pt.3 ...................................................................... Patch Set 5: Code-Review+1 (3 comments) File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/IcebergParquetDataParser.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20648/comment/fab76d58_b52ccfb7?usp=email : PS4, Line 314: LocalDate localDate = (LocalDate) value; > Please check if the value here is local date or long both when the date field > is top level field or […] Iceberg's Parquet reader always returns the type as the logical Java type, in this case, LocalX for each type. Tested and works as expected. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20648/comment/8c1adfe5_84c1aace?usp=email : PS4, Line 320: LocalTime localTime = (LocalTime) value; > same as the previous comment Same as above. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20648/comment/e9167d18_6f917dcc?usp=email : PS4, Line 346: case FLOAT -> ATypeTag.FLOAT; > ATypeTag.Float is returned here but it is serialized as double in the earler > part of the code. […] Fixed, as per the docs, it it safe to serialize as double. https://iceberg.apache.org/spec/#primitive-types -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20648?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I1726c2168bfec1f137390c7c2112c2df59151dc2 Gerrit-Change-Number: 20648 Gerrit-PatchSet: 5 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Comment-Date: Wed, 17 Dec 2025 02:35:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Peeyush Gupta <[email protected]>
